Finish sketch for Citroen C5 X7 Nac operation with arduino Can Comfort 2004-2010.

Ukautotechnic · 18. April 2022

Zitat von Mittns

Zitat von Ukautotechnic

And should it display frames with out me sending a command in serial monitor?

Yes, if the bsi send frames, it should show you in the serial port monitor.

You must think I'm completely thick
But I can't get serial monitor to display anything just the image showed you
Sorry 😭

Zitat von Ukautotechnic

Is the baud rate same for bsi NAC and cluster?

BSI is high speed 500kbps on the diagnostic side (obd) and nac/cluster should be low speed 125kbps, of you connect ot behind the nac/cluster directly.

So if you want to catch alert messages for example, it would be better, if you connect the can high and can low directly to the nac with baudrate 125kpbs.
You can find the pinout from nac/rcc here.

Nac: Pin 10 (Can High) and pin 21 (Can Low).

Alles anzeigen

I'm trying to find out the bsi frame for the start stop button and the NAC start stop touch button but having no success I have the frame sent by the original cluster when start stop/eco switch pressed but need to get the NAC to emulate it now I have cirocco fitted it's just that and the notifications that I need to get working on my vehicle

I have looked around to try to find someone to do it if I pay them as I am totally thick with c++ 😔

Mittns · 18. April 2022

Zitat von Ukautotechnic

I'm trying to find out the bsi frame for the start stop button and the NAC start stop touch button but having no success

You have to configure the option in bsi so that the bsi recognize the frame via touch panel.

Zitat von Ukautotechnic

I have the frame sent by the original cluster when start stop/eco switch pressed but need to get the NAC to emulate it now I have cirocco fitted it's just that and the notifications that I need to get working on my vehicle
I have looked around to try to find someone to do it if I pay them as I am totally thick with c++ 😔

The main thing is, i could write a Sketch for it but it takes a looot of hours, including testing and so on and that's to much for my free time you know.

It's not done in 10 minutes.

If I were to tinker with it myself, it wouldn't be an issue, but I'm not interested in that at the moment.

My priorities are elsewhere at the moment.

Especially since I couldn't test everything anyway, since I only have Peugeot stuff here at home and no Citroen.

Ukautotechnic · 18. April 2022

Zitat von Mittns

Zitat von Ukautotechnic

I'm trying to find out the bsi frame for the start stop button and the NAC start stop touch button but having no success

You have to configure the option in bsi so that the bsi recognize the frame via touch panel.

Zitat von Ukautotechnic

I have the frame sent by the original cluster when start stop/eco switch pressed but need to get the NAC to emulate it now I have cirocco fitted it's just that and the notifications that I need to get working on my vehicle
I have looked around to try to find someone to do it if I pay them as I am totally thick with c++ 😔

The main thing is, i could write a Sketch for it but it takes a looot of hours, including testing and so on and that's to much for my free time you know.
It's not done in 10 minutes.

If I were to tinker with it myself, it wouldn't be an issue, but I'm not interested in that at the moment.
My priorities are elsewhere at the moment.

Especially since I couldn't test everything anyway, since I only have Peugeot stuff here at home and no Citroen.

Alles anzeigen

fully understandable we all know how valuable your time is with other things maybe one day ☺️

Back to the sketches you posted yesterday would like to learn how to use them as I haven't been able to get anything to show in the serial monitor except mcp ok . maybe if you could tell a complete novice how to use the sketches I will then use them to get my frames I need 🤗

The other thing is the start stop is not configured in my bsi it was a frame that I have captured that is sent by the original cluster.

However the cirocco has an eco button connected to it and I intend to look for the frame sent by it and then get this used to send correct frame to the bsi to enable disable the stop start using the eco button like I did with the original cluster and not the touch button.

Maybe one day when you have time we can look at the original post by myself and friend Manuel

So any help with using the sketch from last night much appreciated and thanks for your help I will as promised show my appreciation by using the donate button as at least you haven't shot me down because I don't understand c++ 🤗

Time is precious as we know and respect this and understand you have other commitments.

I do know someone who could write c++

But you did explain to my friend at the start on how this issue could possibly be resolved

Involving buffering of the messages on 1A1 and sending to the NAC if you could give a quick rough idea of how this would need to be done in a way he would understand I can ask another friend to experiment for us

Thank you

Mittns · 18. April 2022

Zitat von Ukautotechnic

maybe if you could tell a complete novice how to use the sketches I will then use them to get my frames I need 🤗

C++ is not "just" explained.

The sketch shows all frames that are on the bus, that's the short explanation.

If no frames are displayed, check the wiring and baud rate.

You can find out exactly how the library of the MCP2515 works in the examples.

To do this, go to "File > Examples > MCP2515"

Each library in the Arduino IDE has some examples with example codes (Sketch).

Zitat von Ukautotechnic

The other thing is the start stop is not configured in my bsi it was a frame that I have captured that is sent by the original cluster.
However the cirocco has an eco button connected to it and I intend to look for the frame sent by it and then get this used to send correct frame to the bsi to enable disable the stop start using the eco button like I did with the original cluster and not the touch button.

It may be that the button is a normal switch and not a bus module.

Therefore, it must be set in the bsi whether it works via a button or via a frame.

Zitat von Ukautotechnic

Maybe one day when you have time we can look at the original post by myself and friend Manuel
So any help with using the sketch from last night much appreciated and thanks for your help I will as promised show my appreciation by using the donate button as at least you haven't shot me down because I don't understand c++ 🤗

I like to help where I can, but you also have to know how much work is behind it.

I would suggest that you read up on C++ first.

Maybe you can already answer some questions yourself.

I'll probably tinker with it later myself, because I still have some ideas with the canbus.

But it will take a while until then.

Zitat von Ukautotechnic

Time is precious as we know and respect this and understand you have other commitments.
I do know someone who could write c++
But you did explain to my friend at the start on how this issue could possibly be resolved
Involving buffering of the messages on 1A1 and sending to the NAC if you could give a quick rough idea of how this would need to be done in a way he would understand I can ask another friend to experiment for us
Thank you

Yes, i said, you need to figure out all frames and redirect it.

That's what this sketch from your post does.

Now all you have to do is figure out what frames you need and where to send them.

As I said, I have neither a Citroën nor a cluster here at home, so I can't test it myself, you have to do that then.

And of course the alerts must be activated in the Nac to show alert messages.

Ukautotechnic · 19. April 2022

this has just been updated but it looks like it is for C5 with the original cluster and NAC if you look at the code

I tried it with my NAC cirroco setup and no different

https://github.com/ludwig-v/ar…551e74a295870aca852e377b8

No idea why the notifications are still not displaying

But this sketch was written by a friend to test and it displays boot open maybe you can understand and see why the previous sketch I sent doesn't work

Thank you

Mittns · 19. April 2022

Zitat von Ukautotechnic

this has just been updated but it looks like it is for C5 with the original cluster and NAC if you look at the code
I tried it with my NAC cirroco setup and no different

https://github.com/ludwig-v/ar…551e74a295870aca852e377b8

Maybe this line in the "if" query is wrong:

Code

bitRead(canMsgRcv.data[2], 6)

For example if the 6th bit of the third Byte isn't 1, the "if" query will be ignored and nothing will be converted here.

Or this 2 lines are wrong:

Code

bitWrite(canMsgSnd.data[2], 7, 1); // NAC / EMF
bitWrite(canMsgSnd.data[2], 6, 0); // CMB

This just edit the third Byte from the message but we don't know the byte here so we can't check if this is correct.

Bitread and bitwrite were probably used here to save RAM, but this function is rubbish for explanations.

Whoever wrote this, could have at least written the bytes (old/new) from the message next to it as a note or something...

You need to know the third byte from the 1A1 message from bsi.

Then convert this byte to the 8 digit binary code (there are several code converters online) and then edit the 6th bit to 0 and the 7th bit to 1.

Then convert it back to a byte value and you see the new converted byte.

After that you know the old and the new converted frame message.

I hope I explained it clearly.

If not, ask again, maybe I can write a better explanation.

In short, we cannot guess from this code what the 3rd incoming byte of the 1A1 message looks like and into which byte it is converted.

We have to know:

-What does the complete frame for the Nac look like

-What does the complete frame from the BSI look like

At least the complete 1A1 message from bsi would help.

Only then can we know if it is correct.

Ukautotechnic · 19. April 2022

When I tried this sketch written by someone else to make the wiper stalk bring up the boot open notification it worked not sure what part he changed to achieve this.

Mittns · 19. April 2022

It's the same procedure.

Here for example

C++

 bitWrite(canMsgSnd.data[1], 6, bitRead(canMsgRcv.data[3], 5)); // Wiper in reverse

In this line the 6th bit of the second Byte of the frame message will be changed and thats's it.

The bit of the second Byte is changed to the value read with bitread.

Bitread reads the value of the 5th bit from the 4th frame message.

It sucks to read but basically nothing more than changing as simple byte like 0xFF to 0xF1 for example.

canMsgSnd.data[0] = Byte 1

canMsgSnd.data[1] = Byte 2 <- This Byte changed

canMsgSnd.data[2] = Byte 3

canMsgSnd.data[3] = Byte 4

canMsgSnd.data[4] = Byte 5

canMsgSnd.data[5] = Byte 6

canMsgSnd.data[6] = Byte 7

canMsgSnd.data[7] = Byte 8

With this shitty unreadable bitWrite and bitRead you have a better performance.

But you're lost if you don't take notes.

Here an example:

Lets say canMsgSnd.data[1] (Byte 2) of the frame message is 0xFF.

Byte Value 0xFF = 11111111 in Bit value

We Change now the 6th bit from 1 to 0 = 11111111 to 11111011

And now we have a new byte value = 0xFB.

Result:

11111111 = 0xFF

11111011 = 0xFB

More examples:

11001100 = 0xCC

10100101 = 0xA5

11010111 = 0xD7

11001001 = 0xC9

So you have the choice to change this example byte value directly from 0xFF to 0xFB OR you change it via binary value 11111111 to 11111011.

It's the same.

The binary code is performance friendly but shit to read.

I hope I was able to write it clearly.

Ukautotechnic · 25. April 2022

hello sir

They have had no luck with the sketch numerous attempts lol have now put the cirocco in my C4 Picasso

But I need to know what frame changes the cirroco display pages in my C5 they changed with the left scroll wheel

But in the Picasso you don't have this wheel so I want to make my left stalk push button change the page

Thanks

Mittns · 25. April 2022

Zitat von Ukautotechnic

hello sir

Zitat von Ukautotechnic

But I need to know what frame changes the cirroco display pages in my C5 they changed with the left scroll wheel
But in the Picasso you don't have this wheel so I want to make my left stalk push button change the page

I would say you have to ask a users who has installed a cirroco or have a scroll wheel in their car.

The various speedometers hardly differ from each other, even if they are installed in different models.

Therefore most frames will be the same.

After that, find the frame from your button that you want to use and redirect it like all other frames.

You can also have a look here.

Some frames are still the same.

Mamalague · 25. April 2022

I have added to the list the rest of the keys that were missing on the C5 X7 steering wheel

Thema

[C5 X7] Can frames Citroen Lenkrad und Konsolenrahmen

Hallo, ich möchte die Werte teilen, die ich vor langer Zeit aus Schlüsseln für die Verwendung in Skizzen im Anwendungsfall für Citroen C5 x7-Funktionen erhalten habe.

I add keys on the left side of the car steering wheel
https://drive.google.com/file/d/1fGj0iRTwAc5ZPdsw9tnA-TROT4G-F2P_/view?usp=sharing

Mamalague

20. März 2022

Mamalague · 1. Februar 2023

Hello, I am getting improvements in the sketch to adapt Nac can 2010 in C5 can 2004 but I have a need to correct, when I have an ice risk warning it remains fixed and hides information from the screen I would like that this warning only be done during a short time of 5 or 10 seconds. Can you help me? I have tried millis but it does not do what I need.

If someone needs the sketch I can send it to them, it is modified to be used in Citroen C5.

line 47 the ice warning code.

Thanks.

Code

sendPOPup(bitRead(canMsgRcv.data[5], 4), 136, 8, 0x00); // Parking assistance system fault (WARNING)

// bitRead(canMsgRcv.data[5], 3); // N/A

// bitRead(canMsgRcv.data[5], 2); // N/A

notificationParameters = 0x00;

bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[5], 1)); // Front left tyre

bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[5], 0)); // Front right tyre

bitWrite(notificationParameters, 5, bitRead(canMsgRcv.data[6], 7)); // Rear right tyre

bitWrite(notificationParameters, 4, bitRead(canMsgRcv.data[6], 5)); // Rear left tyre

sendPOPup((bitRead(canMsgRcv.data[5], 1) || bitRead(canMsgRcv.data[5], 0) || bitRead(canMsgRcv.data[6], 7) || bitRead(canMsgRcv.data[6], 5)), 13, 8, notificationParameters); // Adjust tyre pressures (WARNING)

// bitRead(canMsgRcv.data[6], 5); // Switch off lighting (INFO)

// bitRead(canMsgRcv.data[6], 4); // N/A

sendPOPup((bitRead(canMsgRcv.data[6], 3) || bitRead(canMsgRcv.data[6], 1)), 190, 8, 0x00); // Emissions fault (WARNING)

sendPOPup(bitRead(canMsgRcv.data[6], 2), 192, 8, 0x00); // Emissions fault: Starting Prevented (WARNING)

// bitRead(canMsgRcv.data[6], 0); // N/A

// bitRead(canMsgRcv.data[7], 7); // N/A

// bitRead(canMsgRcv.data[7], 6); // N/A

sendPOPup(bitRead(canMsgRcv.data[7], 5), 215, 10, 0x00); // "P" (INFO)

sendPOPup(bitRead(canMsgRcv.data[7], 4), 216, 10, 0x00); // Ice warning (INFO)

bitWrite(statusOpenings, 7, bitRead(canMsgRcv.data[7], 3)); // Front right door

bitWrite(statusOpenings, 6, bitRead(canMsgRcv.data[7], 2)); // Front left door

bitWrite(statusOpenings, 5, bitRead(canMsgRcv.data[7], 1)); // Rear right door

bitWrite(statusOpenings, 4, bitRead(canMsgRcv.data[7], 0)); // Rear left door

sendPOPup((bitRead(canMsgRcv.data[7], 3) || bitRead(canMsgRcv.data[7], 2) || bitRead(canMsgRcv.data[7], 1) || bitRead(canMsgRcv.data[7], 0) || bitRead(statusOpenings, 3) || bitRead(statusOpenings, 1)), 222, 8, statusOpenings); // Front right door opened (INFO) || Front left door opened (INFO) || Rear right door opened (INFO) || Rear left door opened (INFO)

}

Alles anzeigen

Mittns · 1. Februar 2023

Please use the "Code"-Tag in editor, otherwise it's not possible to read the code.

Edit:

If you use millis, the popup will only recognized in the first 5 seconds.

It should work.

Code

if (millis() <= 5000) {
    sendPOPup(bitRead(canMsgRcv.data[7], 4), 216, 10, 0x00); // Ice warning (INFO)
}

If this doesn't work, you have another problem.

Mamalague · 1. Februar 2023

I try it, thanks

Hello, I have pasted a larger part, so that it can be easier to understand the context. Using millis that way, the warning does not appear at any time. Some tell me the following "the notification or flag activates the presentation for the time of 5 seconds or 5000 msec using millis(). When you exceed it, you set the notification to false and it will not show it anymore." .But I don't know how to apply it. Thank,s

Line 57.

Code

        if (bitRead(canMsgRcv.data[0], 7) == 1 && bitRead(canMsgRcv.data[0], 6) == 0) {
         
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[1], 4)); // Front left tyre
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[1], 3)); // Front right tyre
          bitWrite(notificationParameters, 5, bitRead(canMsgRcv.data[1], 2)); // Rear right tyre
          bitWrite(notificationParameters, 4, bitRead(canMsgRcv.data[1], 1)); // Rear left tyre
          sendPOPup((bitRead(canMsgRcv.data[1], 4) || bitRead(canMsgRcv.data[1], 3) || bitRead(canMsgRcv.data[1], 2) || bitRead(canMsgRcv.data[1], 1)), 13, 6, notificationParameters); // Puncture: Replace or repair the wheel (STOP)
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[1], 0)); // Front right sidelamp
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[2], 7)); // Front left sidelamp
          bitWrite(notificationParameters, 5, bitRead(canMsgRcv.data[2], 6)); // Rear right sidelamp
          bitWrite(notificationParameters, 4, bitRead(canMsgRcv.data[2], 5)); // Rear left sidelamp
          sendPOPup((bitRead(canMsgRcv.data[1], 0) || bitRead(canMsgRcv.data[2], 7) || bitRead(canMsgRcv.data[2], 6) || bitRead(canMsgRcv.data[2], 5)), 160, 6, notificationParameters); // Check sidelamps (WARNING)
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[2], 4)); // Right dipped beam headlamp
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[2], 3)); // Left dipped beam headlamp
          sendPOPup((bitRead(canMsgRcv.data[2], 4) || bitRead(canMsgRcv.data[2], 3)), 154, 6, notificationParameters); // Check the dipped beam headlamps (WARNING)
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[2], 2)); // Right main beam headlamp
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[2], 1)); // Left main beam headlamp
          sendPOPup((bitRead(canMsgRcv.data[2], 2) || bitRead(canMsgRcv.data[2], 1)), 155, 6, notificationParameters); // Check the main beam headlamps (WARNING)
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[2], 0)); // Right brake lamp
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[3], 7)); // Left brake lamp
          sendPOPup((bitRead(canMsgRcv.data[2], 0) || bitRead(canMsgRcv.data[3], 7)), 156, 6, notificationParameters); // Check the RH brake lamp (WARNING) || Check the LH brake lamp (WARNING)
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[3], 6)); // Front right foglamp
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[3], 5)); // Front left foglamp
          bitWrite(notificationParameters, 5, bitRead(canMsgRcv.data[3], 4)); // Rear right foglamp
          bitWrite(notificationParameters, 4, bitRead(canMsgRcv.data[3], 3)); // Rear left foglamp
          sendPOPup((bitRead(canMsgRcv.data[3], 6) || bitRead(canMsgRcv.data[3], 5) || bitRead(canMsgRcv.data[3], 4) || bitRead(canMsgRcv.data[3], 3)), 157, 6, notificationParameters); // Check the front foglamps (WARNING) || Check the front foglamps (WARNING) || Check the rear foglamps (WARNING) || Check the rear foglamps (WARNING)
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[3], 2)); // Front right direction indicator
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[3], 1)); // Front left direction indicator
          bitWrite(notificationParameters, 5, bitRead(canMsgRcv.data[3], 0)); // Rear right direction indicator
          bitWrite(notificationParameters, 4, bitRead(canMsgRcv.data[4], 7)); // Rear left direction indicator
          sendPOPup((bitRead(canMsgRcv.data[3], 2) || bitRead(canMsgRcv.data[3], 1) || bitRead(canMsgRcv.data[3], 0) || bitRead(canMsgRcv.data[4], 7)), 159, 6, notificationParameters); // Check the direction indicators (WARNING)
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[4], 6)); // Right reversing lamp
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[4], 5)); // Left reversing lamp
          sendPOPup((bitRead(canMsgRcv.data[4], 6) || bitRead(canMsgRcv.data[4], 5)), 159, 6, notificationParameters); 
          sendPOPup(bitRead(canMsgRcv.data[5], 4), 136, 8, 0x00); // Parking assistance system fault (WARNING)
          
          notificationParameters = 0x00;
          bitWrite(notificationParameters, 7, bitRead(canMsgRcv.data[5], 1)); // Front left tyre
          bitWrite(notificationParameters, 6, bitRead(canMsgRcv.data[5], 0)); // Front right tyre
          bitWrite(notificationParameters, 5, bitRead(canMsgRcv.data[6], 7)); // Rear right tyre
          bitWrite(notificationParameters, 4, bitRead(canMsgRcv.data[6], 5)); // Rear left tyre
          sendPOPup((bitRead(canMsgRcv.data[5], 1) || bitRead(canMsgRcv.data[5], 0) || bitRead(canMsgRcv.data[6], 7) || bitRead(canMsgRcv.data[6], 5)), 13, 8, notificationParameters); // Adjust tyre pressures (WARNING)
          
          sendPOPup((bitRead(canMsgRcv.data[6], 3) || bitRead(canMsgRcv.data[6], 1)), 190, 8, 0x00); // Emissions fault (WARNING)
          sendPOPup(bitRead(canMsgRcv.data[6], 2), 192, 8, 0x00); // Emissions fault: Starting Prevented (WARNING)
        
          sendPOPup(bitRead(canMsgRcv.data[7], 5), 215, 10, 0x00); // "P" (INFO)

            if (millis() <= 5000) {
             sendPOPup(bitRead(canMsgRcv.data[7], 4), 216, 10, 0x00); // Ice warning (INFO)
            }
          
      //    sendPOPup(bitRead(canMsgRcv.data[7], 4), 216, 10, 0x00); // Ice warning (INFO)

          
          bitWrite(statusOpenings, 7, bitRead(canMsgRcv.data[7], 3)); // Front right door
          bitWrite(statusOpenings, 6, bitRead(canMsgRcv.data[7], 2)); // Front left door
          bitWrite(statusOpenings, 5, bitRead(canMsgRcv.data[7], 1)); // Rear right door
          bitWrite(statusOpenings, 4, bitRead(canMsgRcv.data[7], 0)); // Rear left door
          sendPOPup((bitRead(canMsgRcv.data[7], 3) || bitRead(canMsgRcv.data[7], 2) || bitRead(canMsgRcv.data[7], 1) || bitRead(canMsgRcv.data[7], 0) || bitRead(statusOpenings, 3) || bitRead(statusOpenings, 1)), 222, 8, statusOpenings); // Front right door opened (INFO) || Front left door opened (INFO) || Rear right door opened (INFO) || Rear left door opened (INFO)
        }

Alles anzeigen

james82 · 13. Februar 2023

Hi I have a 2009 Citroen jumpy/dispatch same as Peugeot expert

I have built this adapter and used this sketch

My problems are that I cannot change odometer from kmh to miles.

With the nac installed and the EMF screen still in place the odometer flashes between kmh mph every second

If you unplug the EMF the odometer stays on kmh and the NAC will not change it do any of you genius know what could be the problem and how to resolve it?

I have changed the line bool mpg mph but still the same

As this post is about pop ups these all display fine but I need odometer reading in mph

Thank you

ricky_tz · 17. Februar 2023

Zitat von Mittns

3A7

Hi, I have Pegueot 407 2007 Instrument Cluster and can not find IDs for handing Display popups. Do you maybe know ID? BR

Mamalague · 18. Februar 2023

Hello good, I am learning to be able to send messages to can bus in C5 using an arduino nano and in canano sketch. Using serial

And I have several examples to send.

Example 1:

BUTTON RETURN RIGHT PRESS

ID162

A2

00

10

00

What is the can ID?

I put 162

how many bytes is the message?

I put 6

to add the message I put:

A2 00 10 00 00 00

and then I send.

My first question is if it is.

my second question is how to do it when the message to send is like this.

How do you do it with 217?

Thank you so much.

START/ STOP

535

217

F2

80

00

02

00

FF

I already found out that after the ID in decimal the next bytes are in hexagesimal.

ricky_tz · 18. Februar 2023

Hi, I only have Peugeot 407 cluster. In order to understand your question and help you I need the Arduino sketch that you are currently using.

Mamalague · 18. Februar 2023

C

               // this sketch was brutally hacked together by TJ Bruno --- https://medium.com/@tbruno25

#include <mcp_can.h>
#include <SPI.h>

unsigned long int rxId;
unsigned char len = 0;
unsigned char rxBuf[8];

bool displayOnce;
bool displaySend;
bool x;
bool msgInput;
bool idInput;
bool lengthInput;
bool selection;

byte idLength;

char id[10];
char msg[35];
unsigned char byteMsg[9];

int r;
int t;
int y;
int byteLength;
long int byteId;

String command;

#define CAN0_INT 2                              // Set INT to pin 2
MCP_CAN CAN0(10);                               // Set CS to pin 10


void setup()
{
  Serial.begin(115200);
  if (CAN0.begin(MCP_ANY, CAN_125KBPS, MCP_8MHZ) == CAN_OK)
  {
    CAN0.setMode(MCP_NORMAL);
    pinMode(CAN0_INT, INPUT);
  }
}

void loop1()
{
  if (displayOnce == false) {
    menu();
  }
  while (selection == false)
  {
    if (Serial.available())
    {
      command = Serial.readStringUntil('\n');
      if (command.equals("receive"))
      {
        selection = true;
        loop();
      }
      else if (command.equals("send"))
      {
        selection = true;
        for (int x = 0; x < 50; x++) Serial.println();
        send();
      }
    }
  }
}


void send()
{
  sendMenu();
  clear();
  for (int x = 0; x < 1; x++)
  {
  if (byteId > 2048)
  {
    r = 1;
  }
  else
  {
    r = 0;
  }  
    Serial.print("id = "); Serial.print(byteId, HEX);
    Serial.print("     length =  "); Serial.print(byteLength);
    Serial.print("     msg =  "); while (t < byteLength)
    {
      Serial.print(byteMsg[t], HEX); Serial.print("  "); t++;
    }
    Serial.println(); Serial.println();  Serial.println("To send , press [enter].");
    Serial.println(); Serial.println();
  }
  while (msgInput = true)
  {
    if (Serial.available())
    {
      command = Serial.readStringUntil('\n');
      if (command.equals(""))
      {
        byte sndStat = CAN0.sendMsgBuf(byteId, r, byteLength, byteMsg);
        Serial.println("Message Sent!");
      }
      if (command.equals("C") or command.equals("c"))
      {
        clear();
        t = 0;
        byteLength = "";
        displayOnce = false;
        msgInput = false;
        selection = false;
        loop1();
      }
    }
  }
}


void loop()
{
  while (!digitalRead(CAN0_INT))
  {
    CAN0.readMsgBuf(&rxId, &len, rxBuf);
    Serial.print("FRAME:ID=");
    if ((rxId & 0x80000000) == 0x80000000)
    {
      Serial.print(rxId & 0x1FFFFFFF);
    }
    else
    {
      Serial.print(rxId);
    }
    Serial.print(":LEN=");
    Serial.print(len);
    char msgString[3];
    for (byte i = 0; i < len; i++)
    {
      Serial.print(":");
      snprintf(msgString, 3, "%02X", rxBuf[i]);
      Serial.print(msgString);
    }
    if (Serial.available())
    {
      command = Serial.readStringUntil('\n');
      if (command.equals("C") or command.equals("c"))
      {
        clear();
        selection = false;
        x = false;
        loop1();
      }
    }
    Serial.println();
  }
  if (digitalRead(CAN0_INT))
  {
    if (x == false)
    {
      clear();
      Serial.println("|||||   Nothing to read   |||||   or    |||||   Can bus not detected    |||||");
      for (int x = 0; x < 12 ; x++)Serial.println();
      x = true;
    }
  }
  if (Serial.available())
  {
    command = Serial.readStringUntil('\n');
    if (command.equals("C") or command.equals("c"))
    {
      clear();
      selection = false;
      x = false;
      loop1();
    }
  }
}


void clear()
{
  while (Serial.available())
  {
    char t = Serial.read();
  }
  for (int x = 0; x < 50; x++) Serial.println();      // clear the monitor text
  displayOnce = false;                                //display menu options
}

void menu()
{
  delay(750);
  Serial.println(); Serial.println(); Serial.println();
  Serial.println("Type 'receive' to monitor the bus");
  Serial.println("                or");
  Serial.println("Type 'send' to transmit a message");
  Serial.println(); Serial.println(); Serial.println();
  delay(1000);
  Serial.println("Type 'C' to return back to this menu");
  Serial.println(); Serial.println(); Serial.println(); Serial.println();
  displayOnce = true;
  return;
}


void sendMenu()
{
  Serial.println("What is the can id?");
  Serial.println(); Serial.println(); Serial.println();
  while (idInput == false)
  {
    if (Serial.available())
    {
      Serial.readBytesUntil('\n', id, 10);
      unsigned long k;
      char *endptr;
      k = strtol(id, &endptr, 16);
      byteId = k;
      idInput = true;
    }
  }
  Serial.println("How many bytes is the message?");
  Serial.println(); Serial.println(); Serial.println();
  while (lengthInput == false)
  {
    if (Serial.available())
    {
      byteLength = Serial.parseInt();
      if ((byteLength > 0) && (byteLength < 9))
      {
      lengthInput = true;
      }
    }
  }
  Serial.print("Input the message data"); Serial.print("                  ");
  Serial.print("***NOTE: "); Serial.print("Use the following format:    A1,B2,C3,etc."); Serial.println();
  while (msgInput == false)
  {
    if (Serial.available())
    {
      Serial.readBytesUntil(',', msg, 3);
      int z;
      char *endptr;
      z = strtol(msg, &endptr, 16);
      byteMsg[y - 1] = z;
      y++;
    }
    if (y > byteLength )
    {
      idInput = false;
      lengthInput = false;
      msgInput = true;
      y = 0;
    }
  }
}

Alles anzeigen

Finish sketch for Citroen C5 X7 Nac operation with arduino Can Comfort 2004-2010.

Beitrag von Ukautotechnic (20. Juni 2022)

Jetzt mitmachen!

Teilen

Tags